[SECURITY] Bluetooth: fix OOB read in hci_extended_inquiry_result_evt() (CVE-2020-36386)#141
Open
Mifacopy wants to merge 1 commit intofacebookincubator:oculus-go-kernel-masterfrom
Open
Conversation
meta-cla
bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CVE-2020-36386.
Upstream commit: 51c19bf3d5cfaa66571e4b88ba2a6f6295311101
hci_extended_inquiry_result_evt() only checked that num_rsp != 0, but did not
validate that the skb contains enough bytes for num_rsp * sizeof(*info) plus
the trailing byte. A malformed HCI event with a large num_rsp can therefore
trigger a slab out-of-bounds read, leading to kernel crash/DoS and potential
info exposure.
Add an skb length sanity check and bail out on malformed packets.
Reference: CVE-2020-36386