[SECURITY] USB: visor: fix treo_attach NULL deref on missing endpoints (CVE-2016-2782)#140
Open
Mifacopy wants to merge 1 commit intofacebookincubator:oculus-go-kernel-masterfrom
Open
[SECURITY] USB: visor: fix treo_attach NULL deref on missing endpoints (CVE-2016-2782)#140Mifacopy wants to merge 1 commit intofacebookincubator:oculus-go-kernel-masterfrom
Mifacopy wants to merge 1 commit intofacebookincubator:oculus-go-kernel-masterfrom
Conversation
meta-cla
bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CVE-2016-2782.
Upstream commit: cac9b50b0d75a1d50d6c056ff65c005f3224c8e0
treo_attach() in drivers/usb/serial/visor.c could dereference NULL when a
physically attached USB device is missing the expected bulk-in and/or
interrupt-in endpoint descriptors. A crafted/malicious USB device can
trigger a NULL pointer dereference and crash the kernel (DoS).
Add sanity checks for required endpoints and fail probe/attach cleanly when
descriptors are invalid.
Reference: CVE-2016-2782