[SECURITY] usbip: fix stub_send_ret_submit() null transfer_buffer bug (CVE-2017-16914)#135
Open
Mifacopy wants to merge 1 commit intofacebookincubator:oculus-go-kernel-masterfrom
Open
[SECURITY] usbip: fix stub_send_ret_submit() null transfer_buffer bug (CVE-2017-16914)#135Mifacopy wants to merge 1 commit intofacebookincubator:oculus-go-kernel-masterfrom
Mifacopy wants to merge 1 commit intofacebookincubator:oculus-go-kernel-masterfrom
Conversation
meta-cla
bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CVE-2017-16914.
Upstream commit: be6123df1ea8f01ee2f896a16c2b7be3e4557a5a
In drivers/staging/usbip/stub_tx.c, stub_send_ret_submit() could handle URBs
with actual_length > 0 but transfer_buffer == NULL without checking, which
could result in a NULL pointer dereference when processing crafted USB-over-IP
packets and lead to a denial-of-service (kernel crash).
Add a guard to check that transfer_buffer is non-NULL when actual_length is
greater than zero before proceeding.
Reference: CVE-2017-16914