[SECURITY] USB: mct_u232: add sanity checking in probe (CVE-2016-3136)#133
Open
Mifacopy wants to merge 1 commit intofacebookincubator:oculus-go-kernel-masterfrom
Open
[SECURITY] USB: mct_u232: add sanity checking in probe (CVE-2016-3136)#133Mifacopy wants to merge 1 commit intofacebookincubator:oculus-go-kernel-masterfrom
Mifacopy wants to merge 1 commit intofacebookincubator:oculus-go-kernel-masterfrom
Conversation
meta-cla
bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CVE-2016-3136.
Upstream commit: 4e9a0b05257f29cf4b75f3209243ed71614d062e
The mct_u232 USB serial driver lacked sanity checks in its probe path and
assumed the existence of a second port / second interrupt-in endpoint.
A crafted USB device without the expected endpoint descriptors could trigger
a NULL pointer dereference and crash the kernel (DoS).
Add validation for the second port/interrupt-in URB and fail probe early when
the expected endpoint is missing.
Reference: CVE-2016-3136