[SECURITY] net: sched: validate tcm_info in tc_replace() (CVE-2018-16668)#132
Open
Mifacopy wants to merge 1 commit intofacebookincubator:oculus-go-kernel-masterfrom
Open
[SECURITY] net: sched: validate tcm_info in tc_replace() (CVE-2018-16668)#132Mifacopy wants to merge 1 commit intofacebookincubator:oculus-go-kernel-masterfrom
Mifacopy wants to merge 1 commit intofacebookincubator:oculus-go-kernel-masterfrom
Conversation
meta-cla
bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CVE-2018-16668.
Upstream commit: 4116def2337991b39919f3b448326e21c40e0dbb
In net/sched/sch_api.c, the tc_replace() handler did not properly check the
user-supplied 'tcm_info' structure for valid type and length before use.
Crafted netlink messages could lead to integer overflows and memory corruption
in tc API paths, resulting in denial-of-service or unexpected behavior.
This patch adds sanity checks on tcm_info fields to reject invalid
netlink data early.
Reference: CVE-2018-16668