[SECURITY] PCI: rpadlpar: fix drc_name stack corruption in sysfs store (CVE-2021-28972)#129
Open
Mifacopy wants to merge 1 commit intofacebookincubator:oculus-go-kernel-masterfrom
Open
Conversation
meta-cla
bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CVE-2021-28972.
Upstream commit: cc7a0bb058b85ea03db87169c60c7cfdd5d34678
The RPA PCI Hotplug sysfs handlers add_slot_store() and remove_slot_store()
mishandled drc_name '\0' termination when copying userspace input. This can
lead to a user-tolerable stack buffer overflow / stack corruption (aka
CID-cc7a0bb058b8), allowing userspace to write data into the kernel stack
frame.
Switch to strscpy() to ensure NUL termination and only replace '\n' with '\0'
when present.
Reference: CVE-2021-28972