[SECURITY] xfrm: policy: validate policy direction in xfrm_migrate() (CVE-2017-11600)#123
Open
Mifacopy wants to merge 1 commit intofacebookincubator:oculus-go-kernel-masterfrom
Open
[SECURITY] xfrm: policy: validate policy direction in xfrm_migrate() (CVE-2017-11600)#123Mifacopy wants to merge 1 commit intofacebookincubator:oculus-go-kernel-masterfrom
Mifacopy wants to merge 1 commit intofacebookincubator:oculus-go-kernel-masterfrom
Conversation
meta-cla
bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CVE-2017-11600.
Upstream commit: 7bab09631c2a303f87a7eb7e3d69e888673b9b7e
The 'dir' parameter in xfrm_migrate() is user-controlled and was used as an
array index without validating it against XFRM_POLICY_MAX. This could lead to
out-of-bounds access, kernel lockup, and denial-of-service via a crafted
XFRM_MSG_MIGRATE netlink message when CONFIG_XFRM_MIGRATE is enabled.
This patch adds a sanity check for 'dir' (dir >= XFRM_POLICY_MAX) and rejects
invalid values with -EINVAL.
Reference: CVE-2017-11600