Fix controlled date/time input reset behavior#36471
Conversation
|
Hi @LeSingh1! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Signed the CLA, please re-check. |
|
@meta-cla check |
Summary
Fixes #23299.
For controlled date/time-style inputs, React was syncing defaultValue from value on every update. On iOS Safari/Chrome, the native Reset/Clear button can reset the current value back to defaultValue. Because React kept defaultValue synced to the current value, Reset could become a no-op from React’s value tracking perspective, causing React’s synthetic onChange to be suppressed.
This change preserves the initial defaultValue setup from initInput, but skips later defaultValue syncing from value for date/time-style input types. This allows reset behavior to produce a real value change while keeping controlled value updates intact.
How did you test this change?
yarn prettier
yarn linc
yarn flow dom-node
node ./scripts/jest/jest-cli.js ReactDOMInput-test
node ./scripts/jest/jest-cli.js ChangeEventPlugin
Added a regression test for controlled time inputs to verify that defaultValue is not resynced from value after updates.