[ci] Remove redundant node_modules caches#36457
Open
eps1lon wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
React Core Team
|
Comparing: d5736f0...849243a Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
eps1lon
force-pushed
the
sebbie/05-12-_ci_remove_redundant_node_modules_caches
branch
from
b66d119 to
849243a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did an inventory of our caches and caching of setup-node stood out as redundant. If you use the hash of a lockfile in
actions/cacheand specify the same lockfile incache-dependency-pathofactions/setup-node, your cache key is equivalent.The cache keys for these steps used to be not equivalent due to using different restore-keys. Since https://github.com/facebook/react/pull/33578/changes#r2157682889 we no longer use restore keys though.
Bumped the cache keys where I switched between actions/cache and actions/cache/* to ensure caches are consistent and nothing broke.