Skip to content

fix: potential null dereference in react compiler configuration (#32571) #36163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zendy199x wants to merge 1 commit into from
+1 −1
Closed

fix: potential null dereference in react compiler configuration (#32571) #36163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion babel.config-react-compiler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@
const baseConfig = require('./babel.config-ts');

module.exports = {
plugins: baseConfig.plugins,
plugins: Array.isArray(baseConfig.plugins) ? baseConfig.plugins : [],
Copy link

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fallback will silently drop plugins if baseConfig.plugins is anything other than an array (e.g. a function/object due to a future change), which could lead to the compiler artifact being transformed incorrectly while tests still run. Consider only defaulting for null/undefined and throwing a clear error for other unexpected types so misconfiguration fails fast with a helpful message.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description mentions crashing the build process, but this config appears to be used only by Jest (see scripts/jest/config.base.js transform for the compiler dist file). Consider updating the PR summary/testing notes to reflect that the impact is on local/test transforms rather than the production build, unless there are other consumers not found in-repo.

Copilot uses AI. Check for mistakes.
};
Loading