Migrate RCTAlertManager to handle synchronous void method execution (#56801)#56801
Closed
christophpurrer wants to merge 1 commit into
Closed
Migrate RCTAlertManager to handle synchronous void method execution (#56801)#56801christophpurrer wants to merge 1 commit into
christophpurrer wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104771644. |
…acebook#56801) Summary: In preparation for enabling `enableSyncVoidMethods` (D104331837), which makes TurboModule void methods execute synchronously on the JS thread instead of being dispatched asynchronously. Currently, this module overrides `methodQueue` to return `dispatch_get_main_queue()` so its void methods execute on the main thread. When `enableSyncVoidMethods` is enabled, the `methodQueue` override is ignored for void methods — they execute directly on the JS thread. This causes crashes for any UI operations that must run on the main thread. **Fix:** Remove the `methodQueue` override. The `alertWithArgs` method already dispatches UI work onto the main thread via `RCTExecuteOnMainQueue`, so it is already safe. Changelog: [Internal] Reviewed By: javache Differential Revision: D104771644
meta-codesync
Bot
changed the title
christophpurrer
force-pushed
the
export-D104771644
branch
from
d06e2bc to
774f033
Compare
Collaborator
|
This pull request was successfully merged by @christophpurrer in 0ff4c85 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 0ff4c85. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In preparation for enabling
enableSyncVoidMethods(D104331837), which makes TurboModule void methods execute synchronously on the JS thread instead of being dispatched asynchronously.Currently, this module overrides
methodQueueto returndispatch_get_main_queue()so its void methods execute on the main thread. WhenenableSyncVoidMethodsis enabled, themethodQueueoverride is ignored for void methods — they execute directly on the JS thread. This causes crashes for any UI operations that must run on the main thread.Fix: Remove the
methodQueueoverride. ThealertWithArgsmethod already dispatches UI work onto the main thread viaRCTExecuteOnMainQueue, so it is already safe.Changelog: [Internal]
Reviewed By: javache
Differential Revision: D104771644