[LOCAL][0.83] Add redbox subspec to React-debug pod#56584
Merged
motiz88 merged 1 commit intofacebook:0.83-stablefrom Apr 23, 2026
Merged
[LOCAL][0.83] Add redbox subspec to React-debug pod#56584motiz88 merged 1 commit intofacebook:0.83-stablefrom
motiz88 merged 1 commit intofacebook:0.83-stablefrom
Conversation
meta-cla
Bot
added
the
CLA Signed
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
motiz88
force-pushed
the
fix-react-debug-header-mappings
branch
from
2ed6375 to
d7e7efb
Compare
Add a "redbox" subspec to React-debug.podspec with its own header_dir,
following the same pattern React-Fabric uses for its subdirectories.
Without this, static library builds (without USE_FRAMEWORKS) flatten all
headers into the top-level header_dir ("react/debug"), so imports like
`<react/debug/redbox/RedBoxErrorParser.h>` fail because the "redbox/"
subdirectory is lost.
motiz88
force-pushed
the
fix-react-debug-header-mappings
branch
from
d7e7efb to
e639267
Compare
motiz88
changed the title
motiz88
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a
redboxsubspec toReact-debug.podspecwith its ownheader_dir, following the same patternReact-Fabricuses for its subdirectories.Without this, static library builds (without
USE_FRAMEWORKS) flatten all headers into the top-levelheader_dir(react/debug), so imports like<react/debug/redbox/RedBoxErrorParser.h>fail because theredbox/subdirectory is lost. This broke thetest_e2e_ios_templateappjob after the RedBox 2.0 backport (#56574) added files underReactCommon/react/debug/redbox/.Changelog: [Internal]
Test Plan
CI —
test_e2e_ios_templateappshould no longer fail with'react/debug/redbox/RedBoxErrorParser.h' file not found.