Flatten ReactCxxPlatform timer registry directory structure (#56536)#56536
Closed
javache wants to merge 1 commit intofacebook:mainfrom
Closed
Flatten ReactCxxPlatform timer registry directory structure (#56536)#56536javache wants to merge 1 commit intofacebook:mainfrom
javache wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101811797. |
javache
added a commit
to javache/react-native
that referenced
this pull request
Apr 21, 2026
…#56536) Summary: Pull Request resolved: facebook#56536 Move `PlatformTimerRegistryImpl.{h,cpp}` from `platform/cxx/react/runtime/` to the top level of `ReactCxxPlatform/react/runtime/`. The `platform/cxx/` nesting was an artifact of the multi-platform build setup that is no longer needed since `:timer_registry` is a standalone target. - Remove dead `platform/cxx/react/runtime/*` glob patterns from `:runtime` BUCK target - Remove `platform/cxx/` include directory from CMakeLists.txt - Exported header path unchanged: `react/runtime/PlatformTimerRegistryImpl.h` Differential Revision: D101811797
meta-codesync
Bot
changed the title
javache
force-pushed
the
export-D101811797
branch
from
e3acfd2 to
880d216
Compare
…#56536) Summary: Pull Request resolved: facebook#56536 Move `PlatformTimerRegistryImpl.{h,cpp}` from `platform/cxx/react/runtime/` to the top level of `ReactCxxPlatform/react/runtime/`. The `platform/cxx/` nesting was an artifact of the multi-platform build setup that is no longer needed since `:timer_registry` is a standalone target. - Remove dead `platform/cxx/react/runtime/*` glob patterns from `:runtime` BUCK target - Remove `platform/cxx/` include directory from CMakeLists.txt - Exported header path unchanged: `react/runtime/PlatformTimerRegistryImpl.h` Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D101811797
javache
force-pushed
the
export-D101811797
branch
from
880d216 to
69c8a0d
Compare
|
This pull request has been merged in cdfed83. |
Collaborator
|
This pull request was successfully merged by @javache in cdfed83 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Move
PlatformTimerRegistryImpl.{h,cpp}fromplatform/cxx/react/runtime/to the top level ofReactCxxPlatform/react/runtime/. Theplatform/cxx/nesting was an artifact of the multi-platform build setup that is no longer needed since:timer_registryis a standalone target.platform/cxx/react/runtime/*glob patterns from:runtimeBUCK targetplatform/cxx/include directory from CMakeLists.txtreact/runtime/PlatformTimerRegistryImpl.hChangelog: [Internal]
Reviewed By: christophpurrer
Differential Revision: D101811797