Move VirtualCollection components into react-native-github#56256
Open
CalixTang wants to merge 1 commit intofacebook:mainfrom
Open
Move VirtualCollection components into react-native-github#56256CalixTang wants to merge 1 commit intofacebook:mainfrom
CalixTang wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Moves the core Fling virtual collection components (VirtualRow, VirtualColumn, VirtualCollectionView, and supporting files) from xplat/js/RKJSModules/Libraries/List/ into xplat/js/react-native-github/packages/react-native/src/private/components/virtualcollection/. Updated 40 consumer files to import from 'react-native' instead of Haste and regenerated BUCK files # Changelog: [Internal] Key changes: - Moved 10 files (Virtual, VirtualCollectionView, FlingConstants, VirtualColumn, VirtualColumnGenerator, VirtualRow, VirtualRowGenerator, FlingDebugItemOverlay, getScrollParent, isScrollableNode) into react-native-github - Resolved all fb_internal imports (ReactNativeElement, ReadOnlyElement, ReactNativeFeatureFlags, createHiddenVirtualView) to use relative paths within src/private/ - Converted copyright headers from proprietary to MIT license - Added public re-exports to react-native index.js and index.js.flow (VirtualColumn, VirtualRow, VirtualArray, VirtualCollection, VirtualItem, createVirtualCollectionView, VirtualColumnGenerator, getScrollParent, DEFAULT_INITIAL_NUM_TO_RENDER) Reviewed By: lunaleaps Differential Revision: D98039999
meta-cla
bot
added
the
CLA Signed
|
@CalixTang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D98039999. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Moves the core Fling virtual collection components (VirtualRow, VirtualColumn,
VirtualCollectionView, and supporting files) from xplat/js/RKJSModules/Libraries/List/ into xplat/js/react-native-github/packages/react-native/src/private/components/virtualcollection/.
Updated 40 consumer files to import from 'react-native' instead of Haste and regenerated BUCK files
Changelog: [Internal]
Key changes:
VirtualColumnGenerator, VirtualRow, VirtualRowGenerator, FlingDebugItemOverlay,
getScrollParent, isScrollableNode) into react-native-github
ReactNativeFeatureFlags, createHiddenVirtualView) to use relative paths
within src/private/
(VirtualColumn, VirtualRow, VirtualArray, VirtualCollection, VirtualItem,
createVirtualCollectionView, VirtualColumnGenerator, getScrollParent,
DEFAULT_INITIAL_NUM_TO_RENDER)
Reviewed By: lunaleaps
Differential Revision: D98039999