Skip to content

Fix RCTImageLoader to call completion handler when networking is unavailable #56255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
javache wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

Fix RCTImageLoader to call completion handler when networking is unavailable #56255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/react-native/Libraries/Image/RCTImageLoader.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,17 +714,19 @@ - (RCTImageLoaderCancellationBlock)_loadURLRequest:(NSURLRequest *)request
completionHandler
{
RCTNetworking *networking = [_moduleRegistry moduleForName:"Networking"];
if (RCT_DEBUG && !networking) {
if (!networking) {
RCTLogError(
@"No suitable image URL loader found for %@. You may need to "
" import the RCTNetwork library in order to load images.",
request.URL.absoluteString);
completionHandler(RCTErrorWithMessage(@"RCTNetworking module is not available"), nil, nil);
return NULL;
}

// Check if networking module can load image
if (RCT_DEBUG && ![networking canHandleRequest:request]) {
if (![networking canHandleRequest:request]) {
RCTLogError(@"No suitable image URL loader found for %@", request.URL.absoluteString);
completionHandler(RCTErrorWithMessage(@"No suitable URL loader for request"), nil, nil);
return NULL;
}

Expand Down
Loading