feat: add viewport size to LayoutContext class#56209
Closed
paradowstack wants to merge 1 commit intofacebook:mainfrom
Closed
feat: add viewport size to LayoutContext class#56209paradowstack wants to merge 1 commit intofacebook:mainfrom
paradowstack wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
facebook-github-tools
bot
added
the
Shared with Meta
|
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this in D98004758. |
Collaborator
|
This pull request was successfully merged by @paradowstack in d38c756 When will my fix make it into a release? | How to file a pick request? |
|
@NickGerleman merged this pull request in d38c756. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add viewport size to
LayoutContextand wire it through Android and iOS layout setup so viewport dimensions are available during layout.This was extracted from the larger
calc()work in PR #56162.Changelog:
[GENERAL] [ADDED] - Add viewport size to LayoutContext
Test Plan:
calc()use cases will be covered in the follow-up work that consumes this plumbing.