Fix UIManagerModule.getUIImplementation() to return a non-null UIImplementation#55818
Closed
cortinico wants to merge 1 commit intofacebook:mainfrom
Closed
Fix UIManagerModule.getUIImplementation() to return a non-null UIImplementation#55818cortinico wants to merge 1 commit intofacebook:mainfrom
cortinico wants to merge 1 commit intofacebook:mainfrom
Conversation
…ementation Summary: This unblocks the Android CI on master The deprecated getUIImplementation() method was returning null, which could cause NullPointerExceptions for callers that still depend on it. Return a new UIImplementation instance instead. Changelog: [Internal] - Fix `UIManagerModule.getUIImplementation()` to return a non-null `UIImplementation` instead of null Reviewed By: alanleedev Differential Revision: D94743629
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating Diff in D94743629. |
meta-cla
bot
added
the
CLA Signed
Collaborator
|
This pull request was successfully merged by @cortinico in 4d96fb5 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This unblocks the Android CI on master
The deprecated getUIImplementation() method was returning null, which could
cause NullPointerExceptions for callers that still depend on it. Return a
new UIImplementation instance instead.
Changelog: [Internal] - Fix
UIManagerModule.getUIImplementation()to return a non-nullUIImplementationinstead of nullReviewed By: alanleedev
Differential Revision: D94743629