Skip to content

fix: JSC support — createJSRuntimeFactory compile error & Hermes pods not excluded #55817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tux2nicolae wants to merge 2 commits into from
+5 −1
Closed

fix: JSC support — createJSRuntimeFactory compile error & Hermes pods not excluded #55817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0baa6c
fix: add #else branch to createJSRuntimeFactory for USE_THIRD_PARTY_JSC
tux2nicolae Feb 28, 2026
538a5fb
fix: skip Hermes pods when USE_THIRD_PARTY_JSC is enabled
tux2nicolae Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/react-native/Libraries/AppDelegate/RCTDefaultReactNativeFactoryDelegate.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ - (JSRuntimeFactoryRef)createJSRuntimeFactory
{
#if USE_THIRD_PARTY_JSC != 1
return jsrt_create_hermes_factory();
#else
[NSException raise:@"JSRuntimeFactory"
format:@"createJSRuntimeFactory must be overridden when using third-party JSC"];
return nil;
#endif
}

Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/scripts/react_native_pods.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def use_react_native! (
react_native_path = Pod::Config.instance.installation_root.join(path)
prefix = react_native_path.relative_path_from(Pod::Config.instance.installation_root)

hermes_enabled= true
hermes_enabled= !use_third_party_jsc()
# Set the app_path as env variable so the podspecs can access it.
ENV['APP_PATH'] = app_path
ENV['REACT_NATIVE_PATH'] = react_native_path.to_s
Expand Down