Add module mock for AppLauncher and apply in tests#55728
Open
huntie wants to merge 2 commits intofacebook:mainfrom
Open
Add module mock for AppLauncher and apply in tests#55728huntie wants to merge 2 commits intofacebook:mainfrom
huntie wants to merge 2 commits intofacebook:mainfrom
Conversation
Summary: Renames the **"BrowserLauncher"** concept (`unstable_browserLauncher`) to **"AppLauncher"**, since the scope is now widened to open the desktop debugger shell by default. Also rename and remove `unstable_` prefixes for `launchDebuggerShell` and `prepareDebuggerShell` methods (APIs remain unstable on the root option key). **Why not `DebuggerLauncher`?** This naming remains wide enough to cover other host process delegation in future (e.g. opening other secondary tools, or opening a generic URL in the browser). Debugger launching methods remain specifically named to match their intent. Changelog: [Internal] Differential Revision: D94218654
Summary: Fixes unwanted side effect launches of the debugger shell in tests (likely introduced in D88161573!). Also adds error guard on `DefaultAppLauncher` to ensure that the implementation is always mocked. Changelog: [Internal] Reviewed By: vzaidman Differential Revision: D94230761
meta-cla
bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes unwanted side effect launches of the debugger shell in tests (likely introduced in D88161573!).
Also adds error guard on
DefaultAppLauncherto ensure that the implementation is always mocked.Changelog: [Internal]
Reviewed By: vzaidman
Differential Revision: D94230761