Remove deprecated ShadowNode type aliases#55687
Closed
sammy-SC wants to merge 1 commit intofacebook:mainfrom
Closed
Remove deprecated ShadowNode type aliases#55687sammy-SC wants to merge 1 commit intofacebook:mainfrom
sammy-SC wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Feb 23, 2026
Summary: ## Changelog: [General] [Breaking]: Removing deprecated type aliases. Use the type directly. Remove deprecated type aliases from ShadowNode that were scheduled for deletion in 0.84: - `ShadowNode::Shared` → use `std::shared_ptr<const ShadowNode>` - `ShadowNode::Weak` → use `std::weak_ptr<const ShadowNode>` - `ShadowNode::Unshared` → use `std::shared_ptr<ShadowNode>` - `ShadowNode::ListOfShared` → use `std::vector<std::shared_ptr<const ShadowNode>>` - `ShadowNode::ListOfWeak` → use `std::vector<std::weak_ptr<const ShadowNode>>` Reviewed By: lenaic Differential Revision: D90331085
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Feb 23, 2026
Summary: ## Changelog: [General] [Breaking]: Removing deprecated type aliases. Use the type directly. Remove deprecated type aliases from ShadowNode that were scheduled for deletion in 0.84: - `ShadowNode::Shared` → use `std::shared_ptr<const ShadowNode>` - `ShadowNode::Weak` → use `std::weak_ptr<const ShadowNode>` - `ShadowNode::Unshared` → use `std::shared_ptr<ShadowNode>` - `ShadowNode::ListOfShared` → use `std::vector<std::shared_ptr<const ShadowNode>>` - `ShadowNode::ListOfWeak` → use `std::vector<std::weak_ptr<const ShadowNode>>` Reviewed By: lenaic Differential Revision: D90331085
sammy-SC
force-pushed
the
export-D90331085
branch
from
62a7a10 to
cf0d256
Compare
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Feb 23, 2026
Summary: ## Changelog: [General] [Breaking]: Removing deprecated type aliases. Use the type directly. Remove deprecated type aliases from ShadowNode that were scheduled for deletion in 0.84: - `ShadowNode::Shared` → use `std::shared_ptr<const ShadowNode>` - `ShadowNode::Weak` → use `std::weak_ptr<const ShadowNode>` - `ShadowNode::Unshared` → use `std::shared_ptr<ShadowNode>` - `ShadowNode::ListOfShared` → use `std::vector<std::shared_ptr<const ShadowNode>>` - `ShadowNode::ListOfWeak` → use `std::vector<std::weak_ptr<const ShadowNode>>` Reviewed By: lenaic Differential Revision: D90331085
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Feb 23, 2026
Summary: Pull Request resolved: facebook#55687 ## Changelog: [General] [Breaking]: Removing deprecated type aliases. Use the type directly. Remove deprecated type aliases from ShadowNode that were scheduled for deletion in 0.84: - `ShadowNode::Shared` → use `std::shared_ptr<const ShadowNode>` - `ShadowNode::Weak` → use `std::weak_ptr<const ShadowNode>` - `ShadowNode::Unshared` → use `std::shared_ptr<ShadowNode>` - `ShadowNode::ListOfShared` → use `std::vector<std::shared_ptr<const ShadowNode>>` - `ShadowNode::ListOfWeak` → use `std::vector<std::weak_ptr<const ShadowNode>>` Reviewed By: lenaic Differential Revision: D90331085
sammy-SC
force-pushed
the
export-D90331085
branch
from
cf0d256 to
8f96d00
Compare
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Feb 23, 2026
Summary: ## Changelog: [General] [Breaking]: Removing deprecated type aliases. Use the type directly. Remove deprecated type aliases from ShadowNode that were scheduled for deletion in 0.84: - `ShadowNode::Shared` → use `std::shared_ptr<const ShadowNode>` - `ShadowNode::Weak` → use `std::weak_ptr<const ShadowNode>` - `ShadowNode::Unshared` → use `std::shared_ptr<ShadowNode>` - `ShadowNode::ListOfShared` → use `std::vector<std::shared_ptr<const ShadowNode>>` - `ShadowNode::ListOfWeak` → use `std::vector<std::weak_ptr<const ShadowNode>>` Reviewed By: lenaic Differential Revision: D90331085
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Feb 23, 2026
Summary: ## Changelog: [General] [Breaking]: Removing deprecated type aliases. Use the type directly. Remove deprecated type aliases from ShadowNode that were scheduled for deletion in 0.84: - `ShadowNode::Shared` → use `std::shared_ptr<const ShadowNode>` - `ShadowNode::Weak` → use `std::weak_ptr<const ShadowNode>` - `ShadowNode::Unshared` → use `std::shared_ptr<ShadowNode>` - `ShadowNode::ListOfShared` → use `std::vector<std::shared_ptr<const ShadowNode>>` - `ShadowNode::ListOfWeak` → use `std::vector<std::weak_ptr<const ShadowNode>>` Reviewed By: lenaic Differential Revision: D90331085
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Feb 23, 2026
Summary: ## Changelog: [General] [Breaking]: Removing deprecated type aliases. Use the type directly. Remove deprecated type aliases from ShadowNode that were scheduled for deletion in 0.84: - `ShadowNode::Shared` → use `std::shared_ptr<const ShadowNode>` - `ShadowNode::Weak` → use `std::weak_ptr<const ShadowNode>` - `ShadowNode::Unshared` → use `std::shared_ptr<ShadowNode>` - `ShadowNode::ListOfShared` → use `std::vector<std::shared_ptr<const ShadowNode>>` - `ShadowNode::ListOfWeak` → use `std::vector<std::weak_ptr<const ShadowNode>>` Reviewed By: lenaic Differential Revision: D90331085
sammy-SC
force-pushed
the
export-D90331085
branch
from
8f96d00 to
bbe3fd7
Compare
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Feb 23, 2026
Summary: ## Changelog: [General] [Breaking]: Removing deprecated type aliases. Use the type directly. Remove deprecated type aliases from ShadowNode that were scheduled for deletion in 0.84: - `ShadowNode::Shared` → use `std::shared_ptr<const ShadowNode>` - `ShadowNode::Weak` → use `std::weak_ptr<const ShadowNode>` - `ShadowNode::Unshared` → use `std::shared_ptr<ShadowNode>` - `ShadowNode::ListOfShared` → use `std::vector<std::shared_ptr<const ShadowNode>>` - `ShadowNode::ListOfWeak` → use `std::vector<std::weak_ptr<const ShadowNode>>` Reviewed By: lenaic Differential Revision: D90331085
sammy-SC
force-pushed
the
export-D90331085
branch
from
bbe3fd7 to
cb41538
Compare
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Feb 24, 2026
Summary: ## Changelog: [General] [Breaking]: Removing deprecated type aliases. Use the type directly. Remove deprecated type aliases from ShadowNode that were scheduled for deletion in 0.84: - `ShadowNode::Shared` → use `std::shared_ptr<const ShadowNode>` - `ShadowNode::Weak` → use `std::weak_ptr<const ShadowNode>` - `ShadowNode::Unshared` → use `std::shared_ptr<ShadowNode>` - `ShadowNode::ListOfShared` → use `std::vector<std::shared_ptr<const ShadowNode>>` - `ShadowNode::ListOfWeak` → use `std::vector<std::weak_ptr<const ShadowNode>>` Reviewed By: lenaic Differential Revision: D90331085
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Feb 24, 2026
Summary: ## Changelog: [General] [Breaking]: Removing deprecated type aliases. Use the type directly. Remove deprecated type aliases from ShadowNode that were scheduled for deletion in 0.84: - `ShadowNode::Shared` → use `std::shared_ptr<const ShadowNode>` - `ShadowNode::Weak` → use `std::weak_ptr<const ShadowNode>` - `ShadowNode::Unshared` → use `std::shared_ptr<ShadowNode>` - `ShadowNode::ListOfShared` → use `std::vector<std::shared_ptr<const ShadowNode>>` - `ShadowNode::ListOfWeak` → use `std::vector<std::weak_ptr<const ShadowNode>>` Reviewed By: lenaic Differential Revision: D90331085
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Feb 24, 2026
Summary: ## Changelog: [General] [Breaking]: Removing deprecated type aliases. Use the type directly. Remove deprecated type aliases from ShadowNode that were scheduled for deletion in 0.84: - `ShadowNode::Shared` → use `std::shared_ptr<const ShadowNode>` - `ShadowNode::Weak` → use `std::weak_ptr<const ShadowNode>` - `ShadowNode::Unshared` → use `std::shared_ptr<ShadowNode>` - `ShadowNode::ListOfShared` → use `std::vector<std::shared_ptr<const ShadowNode>>` - `ShadowNode::ListOfWeak` → use `std::vector<std::weak_ptr<const ShadowNode>>` Reviewed By: lenaic Differential Revision: D90331085
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Feb 24, 2026
Summary: ## Changelog: [General] [Breaking]: Removing deprecated type aliases. Use the type directly. Remove deprecated type aliases from ShadowNode that were scheduled for deletion in 0.84: - `ShadowNode::Shared` → use `std::shared_ptr<const ShadowNode>` - `ShadowNode::Weak` → use `std::weak_ptr<const ShadowNode>` - `ShadowNode::Unshared` → use `std::shared_ptr<ShadowNode>` - `ShadowNode::ListOfShared` → use `std::vector<std::shared_ptr<const ShadowNode>>` - `ShadowNode::ListOfWeak` → use `std::vector<std::weak_ptr<const ShadowNode>>` Reviewed By: lenaic Differential Revision: D90331085
sammy-SC
force-pushed
the
export-D90331085
branch
from
cb41538 to
816b7da
Compare
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Feb 24, 2026
Summary: ## Changelog: [General] [Breaking]: Removing deprecated type aliases. Use the type directly. Remove deprecated type aliases from ShadowNode that were scheduled for deletion in 0.84: - `ShadowNode::Shared` → use `std::shared_ptr<const ShadowNode>` - `ShadowNode::Weak` → use `std::weak_ptr<const ShadowNode>` - `ShadowNode::Unshared` → use `std::shared_ptr<ShadowNode>` - `ShadowNode::ListOfShared` → use `std::vector<std::shared_ptr<const ShadowNode>>` - `ShadowNode::ListOfWeak` → use `std::vector<std::weak_ptr<const ShadowNode>>` Reviewed By: lenaic Differential Revision: D90331085
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Feb 24, 2026
Summary: ## Changelog: [General] [Breaking]: Removing deprecated type aliases. Use the type directly. Remove deprecated type aliases from ShadowNode that were scheduled for deletion in 0.84: - `ShadowNode::Shared` → use `std::shared_ptr<const ShadowNode>` - `ShadowNode::Weak` → use `std::weak_ptr<const ShadowNode>` - `ShadowNode::Unshared` → use `std::shared_ptr<ShadowNode>` - `ShadowNode::ListOfShared` → use `std::vector<std::shared_ptr<const ShadowNode>>` - `ShadowNode::ListOfWeak` → use `std::vector<std::weak_ptr<const ShadowNode>>` Reviewed By: lenaic Differential Revision: D90331085
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Feb 24, 2026
Summary: ## Changelog: [General] [Breaking]: Removing deprecated type aliases. Use the type directly. Remove deprecated type aliases from ShadowNode that were scheduled for deletion in 0.84: - `ShadowNode::Shared` → use `std::shared_ptr<const ShadowNode>` - `ShadowNode::Weak` → use `std::weak_ptr<const ShadowNode>` - `ShadowNode::Unshared` → use `std::shared_ptr<ShadowNode>` - `ShadowNode::ListOfShared` → use `std::vector<std::shared_ptr<const ShadowNode>>` - `ShadowNode::ListOfWeak` → use `std::vector<std::weak_ptr<const ShadowNode>>` Reviewed By: lenaic Differential Revision: D90331085
Summary: ## Changelog: [General] [Breaking]: Removing deprecated type aliases. Use the type directly. Remove deprecated type aliases from ShadowNode that were scheduled for deletion in 0.84: - `ShadowNode::Shared` → use `std::shared_ptr<const ShadowNode>` - `ShadowNode::Weak` → use `std::weak_ptr<const ShadowNode>` - `ShadowNode::Unshared` → use `std::shared_ptr<ShadowNode>` - `ShadowNode::ListOfShared` → use `std::vector<std::shared_ptr<const ShadowNode>>` - `ShadowNode::ListOfWeak` → use `std::vector<std::weak_ptr<const ShadowNode>>` Reviewed By: lenaic Differential Revision: D90331085
sammy-SC
force-pushed
the
export-D90331085
branch
from
816b7da to
67b59b6
Compare
|
This pull request has been merged in 1813df7. |
Collaborator
|
This pull request was successfully merged by @sammy-SC in 1813df7 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[General] [Breaking]: Removing deprecated type aliases. Use the type directly.
Remove deprecated type aliases from ShadowNode that were scheduled for deletion in 0.84:
ShadowNode::Shared→ usestd::shared_ptr<const ShadowNode>ShadowNode::Weak→ usestd::weak_ptr<const ShadowNode>ShadowNode::Unshared→ usestd::shared_ptr<ShadowNode>ShadowNode::ListOfShared→ usestd::vector<std::shared_ptr<const ShadowNode>>ShadowNode::ListOfWeak→ usestd::vector<std::weak_ptr<const ShadowNode>>Reviewed By: lenaic
Differential Revision: D90331085