(AI Generated) [RN][Android] Merge ReactTextAnchorViewManager into ReactTextViewManager#55466
Open
NickGerleman wants to merge 1 commit intofacebook:mainfrom
Open
(AI Generated) [RN][Android] Merge ReactTextAnchorViewManager into ReactTextViewManager#55466NickGerleman wants to merge 1 commit intofacebook:mainfrom
NickGerleman wants to merge 1 commit intofacebook:mainfrom
Conversation
…actTextViewManager Summary: ReactTextAnchorViewManager was only extended by ReactTextViewManager, and its methods directly assumed the instantiated class was a ReactTextViewManager. This change eliminates the unnecessary inheritance hierarchy by merging ReactTextAnchorViewManager's functionality directly into ReactTextViewManager. ReactTextViewManager now extends BaseViewManager directly and contains all the prop setters (border, text, selection, etc.) that were previously in ReactTextAnchorViewManager. Changelog: [Internal] Differential Revision: D92635681
meta-cla
bot
added
the
CLA Signed
|
@NickGerleman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92635681. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
ReactTextAnchorViewManager was only extended by ReactTextViewManager, and its
methods directly assumed the instantiated class was a ReactTextViewManager.
This change eliminates the unnecessary inheritance hierarchy by merging
ReactTextAnchorViewManager's functionality directly into ReactTextViewManager.
ReactTextViewManager now extends BaseViewManager directly and contains all the
prop setters (border, text, selection, etc.) that were previously in
ReactTextAnchorViewManager.
Changelog: [Internal]
Differential Revision: D92635681