Added missing tests for Standalone fusebox shell #55460
Open
+166
−85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds the missing test coverage for the standalone Fusebox debugger shell in
StandaloneFuseboxShell-test.First, I added some missing expectation for the success case (
enableStandaloneFuseboxShell=trueand no errors) already present:unstable_prepareFuseboxShellis called just one time during middleware initializationlaunchDebuggerAppWindowis never called when the standalone shell is availableThen, I added the missing test for the case when
unstable_prepareFuseboxShellreturns one of the error code like eg.platform_not_supported(as reported also in the TODO that I removed).In this way now the test is verifying the full behaviour for the new standalone mode for debugger/dev tools.
Changelog:
[GENERAL] [CHANGED] - Added missing tests for Standalone fusebox shell
Test Plan:
StandaloneFuseboxShell-testand verify all tests cases passedDefaultBrowserLauncherinopenDebuggerMiddlewareto verify that the tests were correctly failing