Add integration tests for error preview formatting#55452
Open
emily8rown wants to merge 1 commit intofacebook:mainfrom
Open
Add integration tests for error preview formatting#55452emily8rown wants to merge 1 commit intofacebook:mainfrom
emily8rown wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: This diff adds React Native jsinspector integration tests for the Hermes CDP error preview changes made in D79451147. The new tests cover error description formatting for: - Simple errors with messages - Errors with empty string messages (should omit the colon) - Errors with no message (should omit the colon) - Errors with custom `name` property - Custom error classes (transpiled for Hermes compatibility) - Custom error classes with empty/no messages These tests ensure error previews in the DevTools console correctly display the error name and message, matching V8's behavior. Differential Revision: D91780051
meta-cla
bot
added
the
CLA Signed
|
@emily8rown has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91780051. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds React Native jsinspector integration tests for the Hermes CDP error preview changes made in D79451147.
The new tests cover error description formatting for:
namepropertyThese tests ensure error previews in the DevTools console correctly display the error name and message, matching V8's behavior.
Differential Revision: D91780051