Skip to content

xplat/yoga/yoga/algorithm #55430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
facebook-github-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

xplat/yoga/yoga/algorithm #55430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/react-native/ReactCommon/yoga/yoga/algorithm/CalculateLayout.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@ static void computeFlexBasisForChild(

float childWidth = YGUndefined;
float childHeight = YGUndefined;
SizingMode childWidthSizingMode;
SizingMode childHeightSizingMode;
SizingMode childWidthSizingMode = SizingMode::MaxContent;
SizingMode childHeightSizingMode = SizingMode::MaxContent;

const FloatOptional resolvedFlexBasis = child->resolveFlexBasis(
direction, mainAxis, mainAxisOwnerSize, ownerWidth);
Expand Down Expand Up @@ -709,7 +709,7 @@ static float distributeFreeSpaceSecondPass(

float childCrossSize = YGUndefined;
float childMainSize = updatedMainSize + marginMain;
SizingMode childCrossSizingMode;
SizingMode childCrossSizingMode = SizingMode::MaxContent;
SizingMode childMainSizingMode = SizingMode::StretchFit;

const auto& childStyle = currentLineChild->style();
Expand Down Expand Up @@ -2330,7 +2330,7 @@ bool calculateLayoutInternal(

layout->generationCount = generationCount;

LayoutType layoutType;
LayoutType layoutType = LayoutType::kLayout;
if (performLayout) {
layoutType = !needToVisitNode && cachedResults == &layout->cachedLayout
? LayoutType::kCachedLayout
Expand Down
Loading