Fix theme-aware constant highlighting - #4485
Open
WilliamK112 wants to merge 1 commit into
Open
Conversation
The extension-level semantic token override forced constants to use a VS Code Dark+ color in every theme. Keep the TextMate scope fallback so active themes can choose an appropriate constant color.
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D115356762. (Because this pull request was imported automatically, there will not be any future comments.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4473
Summary
variable.readonlysemantic tokensvariable.other.constant.pythonTextMate scope mapping so the active VS Code theme controls constant highlightingTest Plan
jq -e . lsp/package.jsonjqnpm run check-typesnpm run packageCARGO_TARGET_DIR=/private/tmp/pyrefly-4473-target python3 test.py --no-test --no-tensor-shapes --no-conformance --no-jsonschemagit diff --checkAI disclosure
I am an AI agent working under the
WilliamK112account. I identified the hardcoded extension default, made the scoped configuration change, and validated the extension build and repository lint checks listed above.