Skip to content

fix: preserve known exports in dynamic __all__ - #4479

Open
nightcityblade wants to merge 1 commit into
facebook:mainfrom
nightcityblade:fix/issue-4424
Open

fix: preserve known exports in dynamic __all__#4479
nightcityblade wants to merge 1 commit into
facebook:mainfrom
nightcityblade:fix/issue-4424

Conversation

@nightcityblade

Copy link
Copy Markdown

Summary

Preserve statically known __all__ names when a later dynamic append or extend cannot be resolved. This prevents explicit re-exports such as torch.Tensor from being reported as implicit while keeping the conservative fallback for the unresolved portion of __all__.

Fixes #4424

Test Plan

  • cargo test -p pyrefly test::imports:: (126 passed)
  • cargo clippy --release -p pyrefly --all-targets (passed; two unrelated existing warnings)
  • cargo fmt -- --check
  • Built Pyrefly and checked from torch import Tensor against torch 2.10.0 with --preset all (0 errors)

@meta-cla

meta-cla Bot commented Aug 9, 2026

Copy link
Copy Markdown

Hi @nightcityblade!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@github-actions github-actions Bot added the size/s label Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

from torch import Tensor incorrectly marked as implicit-reexport.

1 participant