fix: preserve known exports in dynamic __all__ - #4479
Conversation
|
Hi @nightcityblade! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Summary
Preserve statically known
__all__names when a later dynamicappendorextendcannot be resolved. This prevents explicit re-exports such astorch.Tensorfrom being reported as implicit while keeping the conservative fallback for the unresolved portion of__all__.Fixes #4424
Test Plan
cargo test -p pyrefly test::imports::(126 passed)cargo clippy --release -p pyrefly --all-targets(passed; two unrelated existing warnings)cargo fmt -- --checkfrom torch import Tensoragainst torch 2.10.0 with--preset all(0 errors)