fix Constrained TypeVar lost after binop #3220#3242
Open
asukaminato0721 wants to merge 1 commit intofacebook:mainfrom
Open
fix Constrained TypeVar lost after binop #3220#3242asukaminato0721 wants to merge 1 commit intofacebook:mainfrom
asukaminato0721 wants to merge 1 commit intofacebook:mainfrom
Conversation
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
There was a problem hiding this comment.
Pull request overview
Fixes a type inference bug in Pyrefly where constrained TypeVars could be widened to their constraint union after binary operations, leading to false-positive operator errors (issue #3220).
Changes:
- Add a regression test covering constrained
TypeVarpreservation through chained binops. - Preserve constrained
TypeVarquantification inbinop_typeswhen the computed result matches theTypeVar’s constraint union.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyrefly/lib/test/operators.rs | Adds a regression testcase reproducing the constrained-TypeVar binop scenario from #3220. |
| pyrefly/lib/alt/operators.rs | Adjusts binop type computation to keep constrained TypeVars quantified when binop results equal their constraint union. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3220
constrained TypeVar binary ops preserve the original quantified T when evaluating over constraints produces the same constraint set.
Test Plan
add test