fix: Resolve TypeVars in generic TypedDict inheritance with Unpack #1922
+52
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pyrefly incorrectly reports type errors when using
Unpackwith aTypedDictthat has aTypeVarin its generic parameter. Pyright handles this correctly.Problem
When using
Unpack[Child[int]]whereChildinherits fromBase[T], Pyrefly failed to properly resolve type parameters through the inheritance chain. Fields inherited from the parent TypedDict retained unresolved TypeVars instead of being substituted with concrete types.Example:
Solution
Modified class_field_to_typed_dict_field() in typed_dict.rs to:
s)
This ensures that when Child[int] inherits from Base[T], the type parameter _T is correctly resolved to int.