Skip to content

fix(utils): resolve relative paths in VscGitEager - #12360

Open
TheRodzz wants to merge 1 commit into
facebook:mainfrom
TheRodzz:fix-vcs-eager-relative-paths
Open

fix(utils): resolve relative paths in VscGitEager#12360
TheRodzz wants to merge 1 commit into
facebook:mainfrom
TheRodzz:fix-vcs-eager-relative-paths

Conversation

@TheRodzz

Copy link
Copy Markdown

Fixes #12322.

The vcsGitEager map keys are absolute paths, but plugins like content-docs and sitemap use aliasedSitePathToRelativePath to generate relative sourceFilePath strings. When these relative paths were passed to getFileLastUpdateInfo, the map lookup failed and returned null.

This PR fixes this by keeping track of the siteDir upon initialization and resolving incoming relative paths against it before looking them up in the map.

@meta-cla

meta-cla Bot commented Aug 13, 2026

Copy link
Copy Markdown

Hi @TheRodzz!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@netlify

netlify Bot commented Aug 13, 2026

Copy link
Copy Markdown

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 7da2300
🔍 Latest deploy log https://app.netlify.com/projects/docusaurus-2/deploys/6a7d3f31109f090008c6ffe5
😎 Deploy Preview https://deploy-preview-12360--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@meta-cla meta-cla Bot added the CLA Signed Signed Facebook CLA label Aug 13, 2026
@meta-cla

meta-cla Bot commented Aug 13, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sitemap <lastmod> is omitted with experimental_vcs: 'default-v2' in Docusaurus 3.10.2

1 participant