Phase 1: Replace typing_extensions.Self with typing.Self#4867
Closed
Balandat wants to merge 1 commit intofacebook:mainfrom
Closed
Phase 1: Replace typing_extensions.Self with typing.Self#4867Balandat wants to merge 1 commit intofacebook:mainfrom
Balandat wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Migrate Self type hint from typing_extensions to the standard library typing module, which is available in Python 3.11+. Files changed: - ax/fb/api/internal_client.py - ax/core/base_trial.py - ax/api/client.py - ax/utils/testing/core_stubs.py Reviewed By: mpolson64 Differential Revision: D91648884
meta-cla
bot
added
the
CLA Signed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4867 +/- ##
==========================================
- Coverage 96.76% 96.75% -0.01%
==========================================
Files 589 589
Lines 61838 61835 -3
==========================================
- Hits 59836 59830 -6
- Misses 2002 2005 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been merged in 4761470. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Migrate Self type hint from typing_extensions to the standard library typing module,
which is available in Python 3.11+.
Files changed:
Reviewed By: mpolson64
Differential Revision: D91648884