Skip to content

Support ScalarizedOutcomeConstraint in _prepare_p_feasible#4856

Open
mgrange1998 wants to merge 1 commit intofacebook:mainfrom
mgrange1998:export-D92185974
Open

Support ScalarizedOutcomeConstraint in _prepare_p_feasible#4856
mgrange1998 wants to merge 1 commit intofacebook:mainfrom
mgrange1998:export-D92185974

Conversation

@mgrange1998
Copy link
Contributor

Summary:
Implementing support for ScalarizedOutcomeConstraint in _prepare_p_feasible and _prepare_p_feasible_per_constraint as specified in the the task T235432214

  1. Modified _prepare_p_feasible (lines 621-642): Replaced the old oc_names loop with direct handling that uses _get_scalarized_constraint_mean_and_sem for ScalarizedOutcomeConstraint instances. This removes the TODO comment for T235432214

  2. Modified _prepare_p_feasible_per_constraint (lines 706-749): Applied the same pattern to properly compute mean/sigma for scalarized constraints using the helper function.

Differential Revision: D92185974

Summary:
Implementing support for ScalarizedOutcomeConstraint in _prepare_p_feasible and _prepare_p_feasible_per_constraint as specified in the the task T235432214                                                                                    
                                                                                                                                                                                                    
1. Modified _prepare_p_feasible (lines 621-642): Replaced the old oc_names loop with direct handling that uses            _get_scalarized_constraint_mean_and_sem for ScalarizedOutcomeConstraint instances. This removes the TODO comment for T235432214     
                                                                                                    
2. Modified _prepare_p_feasible_per_constraint (lines 706-749): Applied the same pattern to properly compute mean/sigma for scalarized constraints using the helper function.

Differential Revision: D92185974
@meta-cla meta-cla bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 4, 2026
@meta-codesync
Copy link

meta-codesync bot commented Feb 4, 2026

@mgrange1998 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92185974.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 93.33333% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.75%. Comparing base (56711df) to head (c44bcb6).

Files with missing lines Patch % Lines
ax/analysis/utils.py 88.63% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4856      +/-   ##
==========================================
- Coverage   96.76%   96.75%   -0.01%     
==========================================
  Files         589      589              
  Lines       61832    61881      +49     
==========================================
+ Hits        59830    59876      +46     
- Misses       2002     2005       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants