Repository navigation
docs(all): mention DOTNET_TieredPGO in help text - #5139
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add documentation about
DOTNET_TieredPGOported from #5135.Based on experimentation, we can't make it the default because the improvement only works in single build mode and make the watch mode worth.
Watch is the daily driver so we don't want to make it worse.
Good candidates to set this env variable is CI or if you don't rely on watch mode (AI are able to use the watch mode for faster feedback loop).
Numbers
Numbers, Fable phase on tests/Js/Main (75 files), medians of interleaved runs:
Single build,
--noCache:Watch mode, same project, 8 edits per scenario:
The first compile saves about 400 ms and each rebuild then costs 70 to 100 ms more, so a watch session is net slower after four to six edits.
It also depends on the project. From the measurements in #5135 (compile phase, median of 5, PGO off vs on):
Note
Happy to make it the default in the future, if we guarantee that it is always a win. Another reason, to make it the default could also be if the watch compilation is so fast that 10-20% worse has an almost negligible impact.