[Repo Assist] [JS/TS + Python] Fix String.Contains ignoring StringComparison argument

[github-actions]

🤖 This PR was created by Repo Assist, an automated AI assistant.

Summary

String.Contains(value, StringComparison) was silently discarding the StringComparison argument and always performing a case-sensitive search. This produced incorrect results, e.g.:

"ABC".Contains("b", StringComparison.OrdinalIgnoreCase) // returns false (wrong — should be true)

Root Cause

In both Replacements.fs (JS/TS) and Python/Replacements.fs, the Contains pattern matched arg :: _ and emitted a compile-time warning plus a case-sensitive indexOf/find call regardless of the second argument.

Fix

JS/TS:

• Added contains(str, pattern, ic) to src/fable-library-ts/String.ts, using the existing cmp() helper (same pattern as startsWith/endsWith)
• Updated Replacements.fs to route Contains(value, comparison) to String.contains from the library

Python:

• Added contains(string, value, comparison) to src/fable-library-py/fable_library/string_.py — pure Python implementation that handles all ignore-case StringComparison variants
• Updated Python/Replacements.fs similarly

Tests:

• Added String.Contains with StringComparison works to tests/Js/Main/StringTests.fs
• Added test String.Contains with StringComparison works to tests/Python/TestString.fs

Trade-offs

The JS contains function uses a character-by-character scan for culture-sensitive comparisons (same strategy as startsWith/endsWith). For the common OrdinalIgnoreCase case the loop's cmp() call uses simple toLowerCase(), which is fast in practice.

Note

🔒 Integrity filter blocked 84 items

The following items were blocked because they don't meet the GitHub integrity level.

• Error doesn't show .fs line number #2052 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• Compile Error when referencing another project with EntryPoint #2366 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• simulate this Test Local Machine Timezone to fix this  #2375 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• StackOverflow with Fable but not with fsc in release #2392 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• Inconsistencies with DateTime string formatting #2408 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• Recursive trait calls not working #2473 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• sorting a Resizearray differs from .NET #2506 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• struct anonymous record member access gets compiled weirdly #2512 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• Return type overloading not supported by op_Implicit. #2564 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• float32 arithmetics #2652 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• Double-to-string format using "G17" does not match .NET #2654 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• DateTimeOffset is handled unexpectedly in frontend #2665 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• ReflectedDecoratorAttribute gives mangled name in MethodInfo #2723 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• AttachMembers doesn't work with inline #2824 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• AttachMembers doesn't work with operators #2825 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• Custom operator not used or resolved for erased type... sometimes. #2915 list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• ... and 68 more items

To allow these resources, lower min-integrity in your GitHub frontmatter:

tools:
  github:
    min-integrity: approved  # merged | approved | unapproved | none

Generated by Repo Assist · ● 7.6M · ◷

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@346204513ecfa08b81566450d7d599556807389f