[Repo Assist] chore(build): fix clean/clean-all inconsistency and remove redundant build step#275
Draft
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
- clean no longer removes src/test obj/bin directories; the comment already said it should preserve these (for faster incremental builds) - clean-all now correctly adds the obj/bin removal on top of clean, making it non-redundant (previously clean and clean-all did the same thing) - remove redundant `dotnet build test` in test recipe; dotnet run already performs an implicit build before executing Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated pull request from Repo Assist, an AI assistant for this repository.
Summary
Fixes two issues in the
justfilebuild system:1.
clean/clean-allinconsistencyThe
cleanrecipe's own comment said it "preserves dotnet obj/bin directories", but the recipe body was deletingsrc/obj,src/bin,test/obj, andtest/bin. This meant:cleanandclean-allproduced exactly the same result —clean-allwas a no-op wrapperjust build(which callsclean) performed a fulldotnet restorefrom scratch, discarding the NuGet package cacheAfter this fix:
cleanremoves only Fable/Python build outputs and example artifacts. The.NET obj/bindirectories are preserved so incrementaldotnet buildis fast.clean-all(viaclean+ explicit removals) fully wipesobj/binand forces a fresh NuGet restore. Use this when you want a guaranteed clean slate.2. Redundant
dotnet buildintestrecipedotnet runalways performs an implicit build before executing. The explicitdotnet build \{\{test_path}}step ran the same compilation twice, adding build time with no benefit. Removed.Impact
just buildandjust testare faster because.NETrestore/compilation is incremental instead of always starting from scratch.cleanvsclean-allsemantics make no difference in CI. The build output is identical.just clean-allis now meaningfully different fromjust clean— use it when you need a true fresh start.Files changed
justfile— four lines removed, one comment updatedNote
🔒 Integrity filter blocked 10 items
The following items were blocked because they don't meet the GitHub integrity level.
list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".To allow these resources, lower
min-integrityin your GitHub frontmatter: