[Repo Assist] test: expand threading and heapq test coverage#274
Draft
github-actions[bot] wants to merge 1 commit intomainfrom
Draft
[Repo Assist] test: expand threading and heapq test coverage#274github-actions[bot] wants to merge 1 commit intomainfrom
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
- TestThreading.fs: add 13 new tests covering Lock (acquire/release/locked, non-blocking acquire), RLock (acquire/release, reentrancy), Event (set/clear/is_set/wait with and without timeout), Thread (start/join/ is_alive lifecycle, name property), and threading module functions (main_thread, current_thread, enumerate). - TestHeapq.fs: add 2 new tests for the previously untested heapreplace function, covering both the return value and heap invariant maintenance. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated pull request from Repo Assist, an AI assistant for this repository.
Summary
Improves test coverage for two stdlib modules that had significant gaps.
TestThreading.fs— 3 tests → 16 tests (+13)The existing file only tested
get_ident,active_count, andlocal. None of the three concrete classes (Lock,RLock,Event) or theThreadclass had any test coverage. New tests cover:Locklocked()state tracking; non-blocking acquire returnsfalsewhen already heldRLockEventfalse;set/cleartoggleis_set;waitreturnstruewhen already set;wait(timeout=0.0)returnsfalsewhen not setThreadjoin;is_alivereflects lifecycle (false→true→false);nameproperty;daemondefaultmain_thread,current_thread,enumerateTestHeapq.fs— 5 tests → 7 tests (+2)heapreplace(pop smallest, push new item atomically) had no tests. New tests verify:Files changed
test/TestHeapq.fs— 2 new tests forheapreplacetest/TestThreading.fs— 13 new tests coveringLock,RLock,Event,Thread, and threading module functionsNo bindings were changed; this is a test-only PR.
Note:
CHANGELOG.mdis intentionally not updated per repository policy.CI will validate the build and Python tests.
Note
🔒 Integrity filter blocked 10 items
The following items were blocked because they don't meet the GitHub integrity level.
list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".To allow these resources, lower
min-integrityin your GitHub frontmatter: