-
Notifications
You must be signed in to change notification settings - Fork 8
feat(loans): overdue recalls (solleciti) and email loan receipt (#360) #362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+2,739
−124
Closed
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
991cc6f
feat(loans): overdue recalls (solleciti) and email loan receipt (#360)
fabiodalez-dev 8bcd2ba
style(loans): match existing admin palette for recall/receipt buttons…
fabiodalez-dev 39fde57
feat(installer): seed recall templates and settings on fresh installs…
fabiodalez-dev 708846a
feat(email): render user-facing emails in the recipient's language (#…
fabiodalez-dev e7d5adc
feat(registration): let the registrant choose their language (#360)
fabiodalez-dev b2d1946
fix(pr-361): address CodeRabbit review findings (#360)
fabiodalez-dev 8cac891
test(migration): behavioural coverage for migrate_0.7.62-rc.1 (#360)
fabiodalez-dev 43bde05
fix(loans): align recall behaviour and MariaDB migration test
fabiodalez-dev b74f838
test(loans): behavioural DB contract for #360 recalls
fabiodalez-dev 43620cd
fix(loans): read the recall schedule via SettingsRepository, not the …
fabiodalez-dev d59f736
fix(e2e): wait for TinyMCE init before setContent in disc-create spec
fabiodalez-dev fa1b2df
fix(loans): address the #360 review follow-ups (recall abuse, UX, con…
fabiodalez-dev 495ab52
test(loans): make the recall behaviour test delete the settings rows …
fabiodalez-dev 0f86044
fix(email): honor the recipient locale when only the installation row…
fabiodalez-dev 644ead4
fix(loans): address the remaining CodeRabbit follow-ups on #361
fabiodalez-dev d679147
test(loans): snapshot the loans.* settings from the DB, not the inert…
fabiodalez-dev 5d996dc
fix(loans): address the #362 review round + per-locale email template…
fabiodalez-dev 7719276
fix(ui): hide the notification badge when the count is zero
fabiodalez-dev 8d2b577
chore(release): mark 0.7.62-rc.1 in the changelog
fabiodalez-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | 🏗️ Heavy lift
🧩 Analysis chain
🏁 Script executed:
Repository: fabiodalez-dev/Pinakes
Length of output: 11168
🏁 Script executed:
Repository: fabiodalez-dev/Pinakes
Length of output: 50379
🏁 Script executed:
Repository: fabiodalez-dev/Pinakes
Length of output: 32597
🌐 Web query:
PHPMailer isMail mail() timeout property PHP mail transport timeout documentation💡 Result:
PHPMailer's $Timeout property is designed specifically for SMTP connections and does not apply to the mail transport method [1][2][3]. When you use the isMail method, PHPMailer uses PHP's internal mail function [4][2], which acts as a wrapper for the system's mail transport agent (typically sendmail or a local SMTP relay) [4][5]. Because the mail function is a thin wrapper that hands off the email to the local system, it does not support timeout configuration via PHPMailer properties [5]. Key takeaways: - SMTP Timeout: The $Timeout property (defaulting to 300 seconds) only applies when PHPMailer uses its own built-in SMTP client (isSMTP) [1][2][6]. - mail Limitations: The mail transport method is synchronous and relies on the configuration and performance of your local server or PHP environment [4]. If the local mail submission process hangs or is slow, PHPMailer has no mechanism to intercept or enforce a timeout on the underlying PHP mail function [5]. - Recommendation: If you require reliable control over timeouts and connection feedback, it is strongly recommended to use isSMTP with a local or remote SMTP server instead of the mail function [4][5]. For scenarios where isSMTP is used, note that there are two separate properties to consider for full control: $Timeout (for the initial connection) and $Timelimit (for individual command responses), which can be accessed via $mail->getSMTPInstance->Timelimit = X; [6][7].
Citations:
🏁 Script executed:
Repository: fabiodalez-dev/Pinakes
Length of output: 350
Imponi un limite effettivo agli invii di
bulkRecall.Se
type = mail,EmailServiceusaisMail()senza applicare$mailer->Timeout. Un MTA locale bloccato può quindi superare i 15 secondi e trattenere il worker HTTP. Usa SMTP con timeout controllato oppure sposta il batch in un job asincrono.🤖 Prompt for AI Agents