Skip to content

ci(zap): stop failing on the ISBN/EAN-13 PII-Disclosure false positive #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fabiodalez-dev wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −3
Open

ci(zap): stop failing on the ISBN/EAN-13 PII-Disclosure false positive #359

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
301f714
ci(zap): stop failing on the ISBN/EAN-13 PII-Disclosure false positive
fabiodalez-dev Aug 17, 2026
8802cc4
ci(zap): narrow the rule-10062 allowlist to ISBN/EAN-13 catalogue fal…
fabiodalez-dev Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions .github/workflows/ci-browser-security.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,12 +163,23 @@ jobs:
- name: Fail on medium or high ZAP alerts
run: |
test -s report_json.json || { echo "ZAP JSON report is missing"; exit 1; }
blocking=$(jq '[.site[]?.alerts[]? | select((.riskcode | tonumber) >= 2)] | length' report_json.json)
# OWASP ZAP rule 10062 (PII Disclosure) is allowlisted NARROWLY, never
# globally. A book catalogue renders ISBN/EAN-13 identifiers on its
# bibliographic pages, and a 13-digit code inherently collides with the
# credit-card Luhn pattern the rule matches (observed: EAN 4131672754818
# on /de/verlag/Puffin+Books, mis-classified as "Visa" because BIN
# 413167 is a Visa range). An alert is ignored ONLY when EVERY instance
# is a 13-digit number on a bibliographic route — a real card leak
# (15/16 digits) or a 13-digit value on any other page still fails the
# build. Real secret/PII exposure is also covered by the secret-scanning,
# Semgrep and CodeQL jobs; every other medium/high alert stays blocking.
FILTER='def is_isbn_fp: (.pluginid // "") == "10062" and ([ .instances[]? | ((.evidence // "") | test("^[0-9]{13}$")) and ((.uri // "") | test("/(auteur|author|autor|autore|book|buch|catalog|catalogo|catalogue|editore|editori|genere|genre|katalog|libro|libri|livre|publisher|verlag)"; "i")) ] | (length > 0 and all)); [ .site[]?.alerts[]? | select((.riskcode | tonumber) >= 2) | select(is_isbn_fp | not) ]'
blocking=$(jq "$FILTER | length" report_json.json)
if [ "$blocking" -gt 0 ]; then
jq -r '.site[]?.alerts[]? | select((.riskcode | tonumber) >= 2) | "[\(.riskdesc)] \(.alert): \(.desc)"' report_json.json
jq -r "$FILTER"' | .[] | "[" + (.riskdesc // "") + "] " + (.alert // "") + ": " + (.desc // "")' report_json.json
exit 1
fi
echo "ZAP found no medium/high passive-scan alerts"
echo "ZAP found no blocking medium/high passive-scan alerts (allowlisted: 13-digit ISBN/EAN codes on bibliographic pages)"

- name: Upload browser and server diagnostics
if: always()
Expand Down