Fix IndexError in convert_size_bytes_to_string for sizes >= 1024 YB#186
Open
SAY-5 wants to merge 1 commit into
Open
Fix IndexError in convert_size_bytes_to_string for sizes >= 1024 YB#186SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
=======================================
Coverage 98.33% 98.33%
=======================================
Files 13 13
Lines 780 780
=======================================
Hits 767 767
Misses 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Owner
|
@SAY-5 thank you for this PR, could you please add tests for converting from string to size and also ensure that size -> string -> size returns the initial value? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
convert_size_bytes_to_string()raisedIndexErrorfor any size of 1024 YB or more (2**90bytes and up), because the unit-selection loop guardfactor <= factor_limitlet the index increment one past the lastSIZE_UNITSentry beforeunits[factor]was read. Changing the guard tofactor < factor_limitstops at the largest unit and clamps the value to YB instead of crashing. Smaller sizes are unaffected.Related issue
#184
Checklist before requesting a review