Allow customizable injection point#61
Open
Preston-Landers wants to merge 1 commit intofaassen:masterfrom
Open
Conversation
Owner
|
Looks like a good patch, but it also needs tests. There is some tricky fallback logic here which uses the We also need some documentation improvements to document this. |
Author
|
Cool. I'll look into some testing and the docs. Honestly I'm not sure the fallback logic is really necessary - and it isn't needed for my personal purposes. |
01e79b9 to
86e4fb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For my use case it's very handy to be able to control the injection point, rather than always at the end of the
</head>tag. This change allows you to choose a different injection point.My reasoning is that sometimes I need to include my own CSS files after a Bower component so the CSS rendering rules prioritize my styles given the same specifier. I think this can probably be accomplished by making all my CSS files a bowerstatic local component, but I prefer having the flexibility over the inclusion point.