-
-
Notifications
You must be signed in to change notification settings - Fork 370
Support ln=target in LS Colors (exa PR 960) #1018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hey, thanks for updating the pr, I will let you fix clippy lints error and check for format error in your code, they are mentionned in the checks not passing |
9b4bee2 to
4f3c057
Compare
MartinFillon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your patience and for fixing everything.
PThorpe92
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
| Target, | ||
| } | ||
|
|
||
| impl Default for LinkStyle { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: can this be derived?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry. I don't know what that means. I don't actually know Rust. I just took the original patch and tweaked it to work with the current code
If you can point me in the right direction though, I'm happy to take a look
Setting "ln=target" highlights a link in the same color as the referred file. Dangling/orphaned links are always colored using the specified "or=" color. (Credit to @LarsHaalck who wrote the original ogham/exa#960)
Setting "ln=target" highlights a link in the same color as the referred file instead of having a specific symlink color. Dangling/orphaned links are always colored using the specified "or=" color.
(Credit to @LarsHaalck who wrote the original ogham/exa#960)