Open
Conversation
- Bump swift-tools-version from 5.3 to 5.7 (required for .tvOS(.v16)) - Add .tvOS(.v16) to Package.swift platforms This enables SVGView to be used as a dependency in tvOS apps. The existing SwiftUI code compiles for tvOS without modification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
swift-tools-versionfrom 5.3 to 5.7 (required for.tvOSplatform specifier with version ≥ 16).tvOS(.v16)to Package.swift platformsRationale
SVGView's SwiftUI code compiles for tvOS without modification. However, without
.tvOSdeclared in the package platforms, downstream packages that depend on SVGView cannot cleanly declare tvOS support themselves.The minimum tvOS version is set to 16.0 because
TapGesture(used inSVGNode.swift:38) requires tvOS 16.0+.The
swift-tools-versionbump from 5.3 to 5.7 is necessary because.tvOS(.v16)is not available in the 5.3 tools version. This should not affect existing iOS, macOS, or watchOS consumers.Motivation
This enables SVGView to be used as a dependency in tvOS apps, specifically to support LaTeXSwiftUI on tvOS (see colinc86/LaTeXSwiftUI#77).
Test plan
🤖 Generated with Claude Code