Prevent the rolling: true option from overriding the saveUnitialized: false option#240
Prevent the rolling: true option from overriding the saveUnitialized: false option#240JamesMGreene wants to merge 1 commit into
rolling: true option from overriding the saveUnitialized: false option#240Conversation
…ed: false` option Fixes expressjs#239
|
@dougwilson: I'm sure you're day-job-and-open-source-swamped like the rest of us but if there is any chance of getting this PR and PR #242 merged and released within the next 2 weeks or so, my team and I would appreciate it! 👍 💝 |
|
Hi James, I got the emails from your issues and pull requests :) Nothing was obviously wrong on this pull request, but I just haven't gotten to an actual computer just yet, only been doing what I can from my phone. I was planning on merging this weekend unless when I sat down to look at the diff there was a glaring issue (I can fix any minor issues without waiting on you). Hopefully it should be smooth. |
|
Sounds good, @dougwilson. Thanks! 👍 I'll keep an eye out for any feedback requiring changes on my part. 👀 |
|
Hi @JamesMGreene , I'm sorry, I had another user just eat up all my time tonight, so I wasn't able to get to your pull requests yet. I may not have any further time over this weekend, but will see what I can do. Sorry for the delay! |
|
No worries, @dougwilson... I understand all too well the wonderful time burden of open source. 💝 |
|
No problem :) Looking now. |
|
Thanks, @dougwilson! |
Prevent the
rolling: trueoption from overriding thesaveUnitialized: falseoption.Fixes #239.