Fix broken sidebar menu links#2363
Open
krzysdz wants to merge 1 commit into
Open
Conversation
One broken menu item in 4.x - `/en/4x/api/request#reqparamname`: separated 4.x and 3.x cases, as 4.x allows a default value (at least according to docs content) Broken menu items in 3.x - `/en/3x/api/application#appallpath-callback--callback-`: moved optional parameter to last pos to match 4.x and 5.x header - `/en/3x/api/application#applistenport-host-backlog-callback`: separated 3.x from 4.x/5.x - `/en/3x/api/application#apprenderview-locals-callback`: renamed `options` to locals (see expressjs@9162fa1) - `/en/3x/api/application#appusepath-callback--callback`: separated 3.x from 4.x/5.x as according to API docs 3.x allows only one function per .use call - `/en/3x/api/request#reqheaderfield`: merged with 4.x/5.x `req.get()` menu header, because it has been this way in old docs and I could not find `req.header()` outside `req.get()` description: https://github.com/expressjs/expressjs.com/blob/old-website/_includes/api/en/3x/req-header.md, https://github.com/expressjs/expressjs.com/blob/9e957d4e2c46a9042e1b4bcf9fcee686e3db5a71/en/api/req-header.jade - `/en/3x/api/response#resclearcookiename--options`: used header from 4.x/5.x (comma moved into []) - `/en/3x/api/response#rescookiename-value--options`: used header from 4.x/5.x (comma moved into []) - `/en/3x/api/response#resdownloadpath--filename--options--fn`: separated 3.x from 4.x/5.x, because signature is different - `/en/3x/api/response#resjsonbody`: separated 3.x from 4.x/5.x, because 3.x allows optional status - `/en/3x/api/response#resjsonpbody`: separated 3.x from 4.x/5.x, because 3.x allows optional status - `/en/3x/api/response#reslocationpath`: renamed 3.x to match 4.x/5.x header - `/en/3x/api/response#resredirectstatus-path`: renamed 3.x to match 4.x/5.x header and updated docs content to match (copied from 4.x) - `/en/3x/api/response#resrenderview--locals--callback`: changed header to match 4.x (callback is optional); the 3.x docs are not great and somewhat differ from JSDoc (https://github.com/expressjs/express/blob/cb59086305367d9fcd7d63b53cfca1a3e4ef77d7/lib/response.js#L808-L846) - `/en/3x/api/response#ressendbody`: separated 3.x from 4.x/5.x, because 3.x allows optional status - `/en/3x/api/response#ressetfield--value`: used header from 4.x/5.x (comma moved into [])
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
In the future we should somehow generate the menu based on the content, because doing it manually is very error-prone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #2359
With this and #2324 (and #2356, which should not be necessary for this), lychee with
--include-fragments(and excluded language versions other than English) reports 0 errors.One broken menu item in 4.x:
/en/4x/api/request#reqparamname: separated 4.x and 3.x cases, as 4.x allows a default value (at least according to docs content)Broken menu items in 3.x:
/en/3x/api/application#appallpath-callback--callback-: moved optional parameter to last pos to match 4.x and 5.x header/en/3x/api/application#applistenport-host-backlog-callback: separated 3.x from 4.x/5.x/en/3x/api/application#apprenderview-locals-callback: renamedoptionsto locals (see 9162fa1)/en/3x/api/application#appusepath-callback--callback: separated 3.x from 4.x/5.x as according to API docs 3.x allows only one function per .use call/en/3x/api/request#reqheaderfield: merged with 4.x/5.xreq.get()menu header, because it has been this way in old docs and I could not findreq.header()outsidereq.get()description:expressjs.com/_includes/api/en/3x/req-header.md
Lines 1 to 16 in 2d4df3f
expressjs.com/en/api/req-header.jade
Lines 1 to 17 in 9e957d4
/en/3x/api/response#resclearcookiename--options: used header from 4.x/5.x (comma moved into [])/en/3x/api/response#rescookiename-value--options: used header from 4.x/5.x (comma moved into [])/en/3x/api/response#resdownloadpath--filename--options--fn: separated 3.x from 4.x/5.x, because signature is different/en/3x/api/response#resjsonbody: separated 3.x from 4.x/5.x, because 3.x allows optional status/en/3x/api/response#resjsonpbody: separated 3.x from 4.x/5.x, because 3.x allows optional status/en/3x/api/response#reslocationpath: renamed 3.x to match 4.x/5.x header/en/3x/api/response#resredirectstatus-path: renamed 3.x to match 4.x/5.x header and updated docs content to match (copied from 4.x)/en/3x/api/response#resrenderview--locals--callback: changed header to match 4.x (callback is optional); the 3.x docs are not great and somewhat differ from JSDoc/en/3x/api/response#ressendbody: separated 3.x from 4.x/5.x, because 3.x allows optional status/en/3x/api/response#ressetfield--value: used header from 4.x/5.x (comma moved into [])