Fix res.render() TypeError for view names ending in '.'#7382
Closed
driphtyio wants to merge 1 commit into
Closed
Conversation
Fixes expressjs#7350 path.extname('index.') returns '.' which is truthy, so Express skips the no-extension fallback and calls require(''), throwing an opaque TypeError. Normalize '.' to empty string so the standard lookup error is returned through the callback.
Contributor
|
Duplicate of #7351 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #7350
Problem
res.render('index.')/app.render('index.')throws an opaqueTypeError: The argument 'id' must be a non-empty stringfromrequire('')instead of returning a proper "Failed to lookup view" error through the callback.Root cause
path.extname('index.')returns'.', which is truthy, so Express skips the "no extension → use default engine" fallback.this.ext.slice(1)becomes'', leading torequire('').Fix
When
path.extname()returns exactly'.'(name ends with a dot), normalizethis.extto empty string so Express falls through to the standard no-extension handling. This produces the expected "Failed to lookup view" error instead of an opaque TypeError.