Add test coverage for req.is() with array argument#7380
Closed
atharv-sys32 wants to merge 1 commit into
Closed
Conversation
The Array.isArray(types) branch at lib/request.js:273 was the only uncovered branch in request.js. Add tests passing an actual array to req.is() to hit that path. Closes expressjs#7348
Contributor
|
Duplicate of #7349 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test cases for passing an array to
req.is(), covering theArray.isArray(types)branch atlib/request.js:273which was previously the only uncovered branch in the file.Tests verify:
falsewhen no types match*/json,text/*)Closes #7348