Skip default logging for client errors#7229
Open
raashish1601 wants to merge 1 commit into
Open
Conversation
krzysdz
suggested changes
May 11, 2026
Contributor
krzysdz
left a comment
There was a problem hiding this comment.
As stated in #2263 (comment), Express should not duplicate the logic from finalhandler and instead the status determined by finalhandler should be passed to the error handler to decide whether a message should be logged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid logging errors from the default final handler when the resolved response status is a client error (
4xx). Server errors continue to be logged in non-test environments.Why
Express currently logs any error object that reaches the default final handler. For expected client errors such as
404or400, this adds noisyconsole.erroroutput even though the response is already a client-error response.Fixes #2263.
Testing
npx mocha --require test/support/env --reporter spec --check-leaks test/app.jsnpx eslint lib/application.js test/app.jsnpm testnpm run lint