Fix: Prevent Content-Type from being set to literal 'false' string#7043
Closed
realMelTuc wants to merge 1 commit intoexpressjs:masterfrom
Closed
Fix: Prevent Content-Type from being set to literal 'false' string#7043realMelTuc wants to merge 1 commit intoexpressjs:masterfrom
realMelTuc wants to merge 1 commit intoexpressjs:masterfrom
Conversation
When mime.contentType() returns false for unrecognized types, res.set() now preserves the original value instead of setting the header to the literal string 'false'. Fixes: Express issue expressjs#7034
Contributor
|
Duplicate of #7035 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When mime.contentType() returns false for unrecognized types, res.set() now preserves the original value instead of setting the header to the literal string 'false'.
Bug Description
Previously, when calling res.set('Content-Type', 'some-custom-type') with an unrecognized type, mime.contentType() would return false, and the header would be set to the literal string "false" instead of preserving the original value.
Root Cause
In lib/response.js, the res.set() function was directly assigning the result of mime.contentType(value) to the value variable without checking if it returned false.
Fix
Modified the Content-Type handling in res.set() to only update the value if mime.contentType() returns a non-false value, preserving the original value otherwise.
Test Added
Added a test case in test/res.set.js to verify that unrecognized Content-Type values are preserved correctly.
Fixes: Express issue #7034