[eas-cli] Fix lint and enforce max-warnings=0 - #4219
Open
wschurman wants to merge 1 commit into
Open
Conversation
wschurman
force-pushed
the
adsjklhdaslhjkadshjl
branch
from
August 17, 2026 17:26
9a583a3 to
4981994
Compare
wschurman
marked this pull request as ready for review
August 17, 2026 17:26
|
✅ Thank you for adding the changelog entry! |
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4219 +/- ##
=======================================
Coverage 63.50% 63.50%
=======================================
Files 1028 1028
Lines 46964 46964
Branches 9861 9861
=======================================
Hits 29819 29819
Misses 17043 17043
Partials 102 102 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Noticed while writing a recent PR that there were a bunch of lint warnings in main, thus adding noise to the process. This PR fixes those warnings and prevents new ones from being added (fails CI).
Test Plan
yarn lint, CI