[worker] Install package managers with Corepack - #4212
Draft
AbbanMustafa wants to merge 1 commit into
Draft
Conversation
|
❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4212 +/- ##
==========================================
+ Coverage 63.52% 63.53% +0.01%
==========================================
Files 1028 1028
Lines 46929 46934 +5
Branches 9849 9851 +2
==========================================
+ Hits 29807 29814 +7
+ Misses 17020 17018 -2
Partials 102 102 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Builds that install a custom Node.js version with Corepack enabled can fail during INSTALL_CUSTOM_TOOLS. corepack enable creates pnpm and Yarn shims, then the worker attempts to overwrite them with npm -g install, which exits with EEXIST.
This affected 251 builds across 138 accounts in the visible hot-log window: Datadog failure cluster.
How
Use Corepack to prepare and activate the requested pnpm and Yarn versions when Corepack is enabled. Keep the existing npm global installation path for builds that do not enable Corepack.
Test Plan