[build-tools] Proxy React Native Maven artifacts - #4196
Open
sjchmiela wants to merge 2 commits into
Open
Conversation
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4196 +/- ##
==========================================
+ Coverage 63.39% 63.39% +0.01%
==========================================
Files 1027 1027
Lines 46881 46888 +7
Branches 9834 9835 +1
==========================================
+ Hits 29715 29722 +7
Misses 17064 17064
Partials 102 102 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
React Native 0.81 and newer support
ENTERPRISE_REPOSITORYfor stable Hermes, React Native Core, and React Native Dependencies artifacts. React Native 0.87 also reads this setting in its experimental Swift Package Manager artifact downloader.Set a system fallback so React Native downloads during
pod installuse the existing EAS CocoaPods cache without replacing a repository configured by the user.React Native source: https://github.com/facebook/react-native/blob/v0.87.0/packages/react-native/scripts/cocoapods/rncore.rb
How
During
pod install, setENTERPRISE_REPOSITORYto<EAS_BUILD_COCOAPODS_CACHE_URL>/repo1.maven.org/maven2only when the user did not set it.The existing proxy mechanisms remain active:
EAS_BUILD_COCOAPODS_CACHE_URLstays set, so the CocoaPods plug-in handles all other supported hosts.https://repo1.maven.org/maven2.This change does not remove the CocoaPods plug-in or curl wrapper.
Test Plan
yarn workspace @expo/build-tools test pod.test.ts --runInBandbundle exec rspec spec/expo_cocoapods_proxy/proxy_spec.rbyarn buildyarn fmt:checkyarn lint(0 errors; existing unrelated warnings remain)